Skip to content

fix: typo #1156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 23, 2023
Merged

fix: typo #1156

merged 4 commits into from
May 23, 2023

Conversation

@liuchengwucn
Copy link
Contributor

目标章节：1-js/05-data-types/12-json

当前上游最新 commit：无

本 PR 所做更改如下：

文件名 参考上游 commit 更改（理由）
article.md 无 更正翻译

@javascript-translate-bot javascript-translate-bot requested a review from a team May 20, 2023 06:25
@CLAassistant
Copy link

CLAassistant commented May 20, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@liuchengwucn
Copy link
Contributor Author

liuchengwucn commented May 21, 2023 •
edited
Loading

目标章节：1-js/06-advanced-functions/10-bind

当前上游最新 commit：733ff69
本 PR 所做更改如下：

文件名 参考上游 commit 更改（理由）
article.md 733ff69 英文原文为“What if we'd like to fix some arguments, but not the context this?”，原翻译“但是这里没有上下文”不是很通顺。

@liuchengwucn
Copy link
Contributor Author

目标章节：1-js/06-advanced-functions/10-bind

当前上游最新 commit：733ff69
本 PR 所做更改如下：

文件名 参考上游 commit 更改（理由）
article.md 733ff69 英文原文为“and first arguments if given.”，原翻译“第一个参数”有误。

songhn233
songhn233 suggested changes May 21, 2023
View reviewed changes
@javascript-translate-bot
Copy link

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@liuchengwucn @songhn233
Update 1-js/06-advanced-functions/10-bind/article.md
b6d6e5f 
Co-authored-by: Songhn <songhn233@gmail.com>
@liuchengwucn
Copy link
Contributor Author

/done

@javascript-translate-bot javascript-translate-bot requested a review from a team May 21, 2023 15:33
songhn233
songhn233 approved these changes May 21, 2023
View reviewed changes
Copy link
Member

@songhn233 songhn233 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leviding leviding merged commit e960370 into javascript-tutorial:master May 23, 2023
@leviding
Copy link
Member

Thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@songhn233 songhn233 songhn233 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

DONE

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@liuchengwucn @CLAassistant @javascript-translate-bot @leviding @songhn233